aggregate function return stream of Entities #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
otaviojava
reviewed
Oct 13, 2023
...src/main/java/org/eclipse/jnosql/databases/mongodb/communication/MongoDBDocumentManager.java
Outdated
Show resolved
Hide resolved
otaviojava
reviewed
Oct 13, 2023
...l-mongodb/src/main/java/org/eclipse/jnosql/databases/mongodb/communication/MongoDBUtils.java
Outdated
Show resolved
Hide resolved
should be left private
otaviojava
reviewed
Oct 13, 2023
| Aggregates.match(eq("name", "Poliana")), | ||
| Aggregates.group("$stars", Accumulators.sum("count", 1)) | ||
| ); | ||
| }; |
There was a problem hiding this comment.
Could you also create a test for the new aggregate?
There was a problem hiding this comment.
I do not have dockerized test. just expect it shouldn't fail...
dearrudam
requested changes
Oct 13, 2023
...src/main/java/org/eclipse/jnosql/databases/mongodb/communication/MongoDBDocumentManager.java
Outdated
Show resolved
Hide resolved
dearrudam
approved these changes
Oct 14, 2023
|
@dearrudam did you run it locally? |
No @otaviojava , I didn't it yet... I'm going to do it asap! |
|
@otaviojava @redmitry , it works! |
|
Thank you Max |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopt MongoDBTemplate aggregate to NoSQL model.
see: [msg00661] (https://www.eclipse.org/lists/jnosql-dev/msg00661.html)
N.B. This patch breaks compatibility with previous aggregate interface!