Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArangoDB: fixed driver lifecycle #296

Merged
merged 1 commit into from
Nov 13, 2024
Merged

ArangoDB: fixed driver lifecycle #296

merged 1 commit into from
Nov 13, 2024

Conversation

rashtao
Copy link
Contributor

@rashtao rashtao commented Nov 13, 2024

Changes

This PR fixes the shutdown of ArangoDB driver instances, delegating this responsibility to ArangoDBDocumentManager and ArangoDBBucketManager.

It changes the current behavior in the following way:

  • each instance of ArangoDBDocumentManager and ArangoDBBucketManager has its own ArangoDB driver instance
  • ArangoDBDocumentManager and ArangoDBBucketManager are responsible to shutdown their own driver instances

Cleanup of ArangoDB sync builder (ArangoDBBuilderSync).

@genie-jnosql
Copy link
Collaborator

Can one of the admins verify this patch?

@otaviojava otaviojava merged commit f11bdb4 into eclipse-jnosql:main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviojava otaviojava otaviojava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rashtao @genie-jnosql @otaviojava