-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment only out of .json files #222 Bug Fix #245
Deployment only out of .json files #222 Bug Fix #245
Conversation
Signed-off-by: Anish Vallolikalathil Achuthadas <[email protected]>
9d5905c
to
83aa689
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is about the deployment service, not the CLI create command. Deployment service allows containers to be created and started automatically from CM daemon upon start. Check /containerm/deployment/deployment.go file and the Deployment properties in the doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add unit tests for the new checks in cli_command_ctrs_create_test.go and deployment_test.go.
- Make sure that the code passes the validation workflow:
- gofmt -l .
- golint -set_exit_status ./...
- go vet ./...
- go test ./...
Deployment only out of .json files #222 Bug Fix