Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update createToken.py #1

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Update createToken.py #1

merged 1 commit into from
Mar 4, 2024

Conversation

erikbosch
Copy link
Contributor

Origin eclipse/kuksa.val#676

As this is the agreed master repo we should better delete it from kuksa.val and refer to the location here instead

@erikbosch erikbosch mentioned this pull request Mar 1, 2024
Merged
SebastianSchildt
SebastianSchildt requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the immense pleasure to inform you, the PR is unfortunately blocked by linter, iow, you shot yourself in the 🦶

@erikbosch
Copy link
Contributor Author

That is what happens when you do not follow the instructions and do pre-commit install locally. PR updated, updated also some action-versions

SebastianSchildt
SebastianSchildt approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🍸

@SebastianSchildt SebastianSchildt merged commit 0bf0c75 into eclipse-kuksa:main Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebastianSchildt SebastianSchildt SebastianSchildt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikbosch @SebastianSchildt