-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare Release 0.4.6 #42
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #42 +/- ##
=======================================
Coverage 50.92% 50.92%
=======================================
Files 31 31
Lines 11878 11878
=======================================
Hits 6049 6049
Misses 5829 5829 ☔ View full report in Codecov by Sentry. |
@SebastianSchildt - Databroker fails due to a license change. I have informed @rafaeling on how to update https://github.com/eclipse-kuksa/kuksa-common/tree/main/sbom-tools But I was thinking - pointing to a specific commit makes it cumbersome to update reference in all repos affected. Would it be an idea in kuksa-common to have a tag process similar to what we have for kuksa-actions. I.e. for a minor change like this increase minor version but at the same time just move the major tag. I.e. assuming that current version is 1.0 do the change, tag it as |
@erikbosch : yes probably tagging makes sense Interesting that something changed here. Is it new sub-dependency or realy changed? I assume from Cargo lock? Dash still happy, the only findings are "normal" version bumps it seems
|
Ah checked wrong worklfow, dash also has more
|
eclipse-kuksa/kuksa-common#5 has been merged Leave it up to you and @erikbosch how to update tags/CI to use new sbom-tool version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK. I do not really have any opinion on if you we should use tag or ref for kuksa-common. I am happy to merge if you do no want to do any more changes @rafaeling
Just a friendly reminder, after you merge this to master, some new dash tickets will be created. Pleae wait with (draft) release until no open tickets in (No open tickets is always safe choice. Currently there are some pending from kuksa-python-sdk fixes, so „no more triggered by databroker“ would also be fine. But anyway. None is best) |
bde4443
to
c5b1c84
Compare
c5b1c84
to
4296b0d
Compare
Not many changes compared to the last release 0.4.5: