Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare Release 0.4.6 #42

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Conversation

rafaeling
Copy link
Contributor

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.92%. Comparing base (8eb7d1a) to head (4296b0d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #42   +/-   ##
=======================================
  Coverage   50.92%   50.92%           
=======================================
  Files          31       31           
  Lines       11878    11878           
=======================================
  Hits         6049     6049           
  Misses       5829     5829           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erikbosch
Copy link
Contributor

@SebastianSchildt - Databroker fails due to a license change. I have informed @rafaeling on how to update https://github.com/eclipse-kuksa/kuksa-common/tree/main/sbom-tools

But I was thinking - pointing to a specific commit makes it cumbersome to update reference in all repos affected. Would it be an idea in kuksa-common to have a tag process similar to what we have for kuksa-actions. I.e. for a minor change like this increase minor version but at the same time just move the major tag. I.e. assuming that current version is 1.0 do the change, tag it as 1.1and at the same time move the 1 tag to point at 1.1

@SebastianSchildt
Copy link
Contributor

@erikbosch : yes probably tagging makes sense

Interesting that something changed here. Is it new sub-dependency or realy changed? I assume from Cargo lock? Dash still happy, the only findings are "normal" version bumps it seems

[main] INFO Querying Eclipse Foundation for license data for 163 items.
[main] INFO Found 51 items.
[main] INFO Querying ClearlyDefined for license data for 112 items.
[main] INFO Found 112 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/httparse/1.9.3
[main] INFO crate/cratesio/-/regex-automata/0.4.7
[main] INFO crate/cratesio/-/regex/1.10.5
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.

@SebastianSchildt
Copy link
Contributor

Ah checked wrong worklfow, dash also has more

[main] INFO Querying Eclipse Foundation for license data for 218 items.
[main] INFO Found 54 items.
[main] INFO Querying ClearlyDefined for license data for 164 items.
[main] INFO Found 164 items.
[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO crate/cratesio/-/httparse/1.9.3
[main] INFO crate/cratesio/-/icu_collections/1.5.0
[main] INFO crate/cratesio/-/icu_locid/1.5.0
[main] INFO crate/cratesio/-/icu_locid_transform/1.5.0
[main] INFO crate/cratesio/-/icu_locid_transform_data/1.5.0
[main] INFO crate/cratesio/-/icu_normalizer/1.5.0
[main] INFO crate/cratesio/-/icu_normalizer_data/1.5.0
[main] INFO crate/cratesio/-/icu_properties/1.5.0
[main] INFO crate/cratesio/-/icu_properties_data/1.5.0
[main] INFO crate/cratesio/-/icu_provider/1.5.0
[main] INFO crate/cratesio/-/icu_provider_macros/1.5.0
[main] INFO crate/cratesio/-/idna/1.0.0
[main] INFO crate/cratesio/-/litemap/0.7.3
[main] INFO crate/cratesio/-/regex-automata/0.4.7
[main] INFO crate/cratesio/-/regex/1.10.5
[main] INFO crate/cratesio/-/tinystr/0.7.6
[main] INFO crate/cratesio/-/utf16_iter/1.0.5
[main] INFO crate/cratesio/-/utf8_iter/1.0.4
[main] INFO crate/cratesio/-/write16/1.0.0
[main] INFO crate/cratesio/-/writeable/0.5.5
[main] INFO crate/cratesio/-/yoke-derive/0.7.4
[main] INFO crate/cratesio/-/yoke/0.7.4
[main] INFO crate/cratesio/-/zerofrom-derive/0.1.4
[main] INFO crate/cratesio/-/zerofrom/0.1.4
[main] INFO crate/cratesio/-/zerovec-derive/0.10.2
[main] INFO crate/cratesio/-/zerovec/0.10.2
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.

@SebastianSchildt
Copy link
Contributor

eclipse-kuksa/kuksa-common#5 has been merged

Leave it up to you and @erikbosch how to update tags/CI to use new sbom-tool version

erikbosch
erikbosch previously approved these changes Jun 12, 2024
Copy link
Contributor

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. I do not really have any opinion on if you we should use tag or ref for kuksa-common. I am happy to merge if you do no want to do any more changes @rafaeling

@SebastianSchildt
Copy link
Contributor

Just a friendly reminder, after you merge this to master, some new dash tickets will be created. Pleae wait with (draft) release until no open tickets in

https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/?sort=created_date&state=opened&author_username=Kuksa-bot&first_page_size=20

(No open tickets is always safe choice. Currently there are some pending from kuksa-python-sdk fixes, so „no more triggered by databroker“ would also be fine. But anyway. None is best)

@erikbosch erikbosch merged commit c47284e into eclipse-kuksa:main Jun 14, 2024
24 checks passed
@erikbosch erikbosch deleted the prep-rel-0.4.6 branch June 14, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants