Feature: Add PublishValue and Subscribe from kuksa.val.v2 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
reviewed
Sep 10, 2024
| path = submodules/kuksa-databroker | ||
| url = https://github.com/eclipse-kuksa/kuksa-databroker | ||
| url = https://github.com/boschglobal/kuksa-databroker.git |
There was a problem hiding this comment.
Is this supposed to be a temporary solution until it is merged? And after that "hardcoded" to a specific comment just like today?
erikbosch
reviewed
Sep 10, 2024
| @@ -55,6 +56,7 @@ class VSSClient(BaseVSSClient): | |||
| def __init__(self, *args, **kwargs): | |||
| super().__init__(*args, **kwargs) | |||
| self.channel = None | |||
| self.channel2 = None | |||
There was a problem hiding this comment.
Should we possibly call them channel_v1 and channel_v2. To make sure that that the number refers to a version and not just arbitrary channels
erikbosch
reviewed
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies as well the generation of the files from submodules. Needs to be checked if this works as well for the pypi package or if we need to change back.