Revert "deleteUser has again a path parameter"

This reverts commit fa214e8.
eclipse-kura · Oct 4, 2023 · e95867b · e95867b
1 parent f401847
commit e95867b
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 6 deletions.
diff --git a/...r/src/main/java/org/eclipse/kura/internal/rest/identity/provider/IdentityRestService.java b/...r/src/main/java/org/eclipse/kura/internal/rest/identity/provider/IdentityRestService.java
@@ -20,7 +20,6 @@
 import javax.ws.rs.GET;
 import javax.ws.rs.POST;
 import javax.ws.rs.Path;
-import javax.ws.rs.PathParam;
 import javax.ws.rs.Produces;
 import javax.ws.rs.core.MediaType;
 import javax.ws.rs.core.Response;
@@ -116,11 +115,12 @@ public Response createUser(final UserDTO userName) {
 
     @DELETE
     @RolesAllowed(REST_ROLE_NAME)
-    @Path("/users/{userName}")
-    public Response deleteUser(@PathParam("userName") final String userName) {
+    @Path("/users")
+    @Consumes(MediaType.APPLICATION_JSON)
+    public Response deleteUser(final UserDTO userName) {
         try {
             logger.debug(DEBUG_MESSAGE, "deleteUser");
-            this.identityService.deleteUser(userName);
+            this.identityService.deleteUser(userName.getUserName());
         } catch (Exception e) {
             throw DefaultExceptionHandler.toWebApplicationException(e);
         }

diff --git a/...ain/java/org/eclipse/kura/internal/rest/identity/provider/test/IdentityEndpointsTest.java b/...ain/java/org/eclipse/kura/internal/rest/identity/provider/test/IdentityEndpointsTest.java
@@ -100,8 +100,8 @@ public void shouldInvokeDeleteUserSuccessfully() {
 
         givenUser(new UserDTO("testuser", Collections.emptySet(), true, false, "testpassw"));
 
-        whenRequestIsPerformed(new MethodSpec(METHOD_SPEC_DELETE, MQTT_METHOD_SPEC_DEL),
-                "/users/" + this.user.getUserName());
+        whenRequestIsPerformed(new MethodSpec(METHOD_SPEC_DELETE, MQTT_METHOD_SPEC_DEL), "/users",
+                gson.toJson(this.user));
 
         thenRequestSucceeds();
         thenResponseBodyIsEmpty();
@@ -168,6 +168,33 @@ private static void givenIdentityService() {
         when(identityServiceMock.getUserConfig()).thenReturn(userConfigs);
     }
 
+    // @Test
+    // public void shouldRethrowWebApplicationExceptionOnReloadSecurityPolicyFingerprint() throws KuraException {
+    // givenFailingIdentityService();
+    //
+    // whenRequestIsPerformed(new MethodSpec(METHOD_SPEC_POST), "/security-policy-fingerprint/reload");
+    //
+    // thenResponseCodeIs(Status.INTERNAL_SERVER_ERROR.getStatusCode());
+    // }
+    //
+    // @Test
+    // public void shouldRethrowWebApplicationExceptionOnReloadCommandLineFingerprint() throws KuraException {
+    // givenFailingIdentityService();
+    //
+    // whenRequestIsPerformed(new MethodSpec(METHOD_SPEC_POST), "/command-line-fingerprint/reload");
+    //
+    // thenResponseCodeIs(Status.INTERNAL_SERVER_ERROR.getStatusCode());
+    // }
+    //
+    // @Test
+    // public void shouldRethrowWebApplicationExceptionOnGetDebugStatus() throws KuraException {
+    // givenFailingIdentityService();
+    //
+    // whenRequestIsPerformed(new MethodSpec(METHOD_SPEC_GET), "/debug-enabled");
+    //
+    // thenResponseCodeIs(Status.INTERNAL_SERVER_ERROR.getStatusCode());
+    // }
+
     @BeforeClass
     public static void setUp() throws Exception {
         createIdentityServiceMock();