feat: Firewall IPV6 support in UI #4805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MMaiero
force-pushed
the
ipv6_firewall_UI
branch
from
fa7a42e to
896004b
Compare
pierantoniomerlino
force-pushed
the
ipv6_firewall_UI
branch
2 times, most recently
from
48bf76b to
5b0b8b0
Compare
pierantoniomerlino
requested review from
mattdibi
and removed request for
pierantoniomerlino
MMaiero
force-pushed
the
ipv6_firewall_UI
branch
from
5b0b8b0 to
016ebd3
Compare
pierantoniomerlino
force-pushed
the
ipv6_firewall_UI
branch
2 times, most recently
from
16cdf13 to
97889fe
Compare
pierantoniomerlino
force-pushed
the
ipv6_firewall_UI
branch
from
dea99cd to
6a7477f
Compare
Signed-off-by: MMaiero <[email protected]> Implemented missing methods for ipv6 firewall webui Signed-off-by: pierantoniomerlino <[email protected]> Fixed ipv4/6 validators Signed-off-by: pierantoniomerlino <[email protected]> Fixed portforwarding ipv6 Signed-off-by: pierantoniomerlino <[email protected]> Added default single host netmask value Signed-off-by: pierantoniomerlino <[email protected]> Fixed ip6address in port forward config Signed-off-by: pierantoniomerlino <[email protected]> Refactored gwt firewall methods Signed-off-by: pierantoniomerlino <[email protected]> Fixed ipv6 address validator Signed-off-by: pierantoniomerlino <[email protected]> Updated messages and tooltips Signed-off-by: pierantoniomerlino <[email protected]> Aligned unknown net value in update methods Signed-off-by: pierantoniomerlino <[email protected]> Fixed linux.net.iptables tests Signed-off-by: pierantoniomerlino <[email protected]>
pierantoniomerlino
force-pushed
the
ipv6_firewall_UI
branch
from
6a7477f to
668f31b
Compare
mattdibi
requested changes
Oct 23, 2023
....kura.linux.net/src/main/java/org/eclipse/kura/linux/net/iptables/AbstractLinuxFirewall.java
Outdated
Show resolved
Hide resolved
....eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/firewall/NatIPv6TabUi.ui.xml
Outdated
Show resolved
Hide resolved
...se.kura.web2/src/main/java/org/eclipse/kura/web/client/ui/firewall/OpenPortsIPv6TabUi.ui.xml
Show resolved
Hide resolved
...org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/util/TextFieldValidator.java
Outdated
Show resolved
Hide resolved
...org.eclipse.kura.web2/src/main/java/org/eclipse/kura/web/client/util/TextFieldValidator.java
Show resolved
Hide resolved
...eclipse.kura.web2/src/main/java/org/eclipse/kura/web/server/GwtNetworkServiceImplFacade.java
Show resolved
Hide resolved
....eclipse.kura.web2/src/main/java/org/eclipse/kura/web/server/net2/GwtNetworkServiceImpl.java
Outdated
Show resolved
Hide resolved
....eclipse.kura.web2/src/main/java/org/eclipse/kura/web/server/net2/GwtNetworkServiceImpl.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Oct 23, 2023
.../org.eclipse.kura.linux.net/src/main/java/org/eclipse/kura/linux/net/iptables/LocalRule.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Oct 23, 2023
.../org.eclipse.kura.linux.net/src/main/java/org/eclipse/kura/linux/net/iptables/LocalRule.java
Outdated
Show resolved
Hide resolved
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
mattdibi
approved these changes
Oct 23, 2023
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the webUI part to configure the IPv6 Firewall.
Description of the solution adopted: Along with the usual IPv4 firewall tabs, three new ones are added to allow the user to configure the IPv6 firewall. The tabs are:
The field validators, error messages and tooltips are updated accordingly. The old tabs are renamed with the IPv4 suffix.