-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web2): Wpa enterprise EAP-TLS certificate support frontend #4881
feat(web2): Wpa enterprise EAP-TLS certificate support frontend #4881
Conversation
bc29db3
to
2b57380
Compare
Co-authored-by: Mattia Dal Ben <[email protected]>
…to the configuration service and applied
2b57380
to
67fa284
Compare
Almost ready for review: |
Tested this at d4d9c2e in #4872. Looking good so far! @GregoryIvo one question: do we really need two different fields for passing the client key if they are the same? ... or did I do something wrong? |
This is correct, and expected. I was thinking about that too but am torn because I like the potential flexibility |
As a user I find it confusing... Why should I set the same for both if I added it as a single Pub/Priv key pair? Also I have a hard time imagining a situation in which this flexibility could be taken advantage of? Can you explain to me a scenario where these two separated fields can be useful? 🤔 |
Superseded by #4895 |
This PR adds front-end support for: #4872
Brief description of the PR. [e.g. Added
null
check onobject
to avoidNullPointerException
]Related Issue: This PR fixes/closes {issue number}
Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped
Screenshots: If applicable, add screenshots to help explain your solution
Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review
Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]