Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web2): Wpa enterprise EAP-TLS certificate support frontend #4881

Conversation

GregoryIvo
Copy link
Contributor

@GregoryIvo GregoryIvo commented Oct 6, 2023

This PR adds front-end support for: #4872

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

Related Issue: This PR fixes/closes {issue number}

Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped

Screenshots: If applicable, add screenshots to help explain your solution

Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review

Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]

@GregoryIvo
Copy link
Contributor Author

V1 Web UI
image

I am now testing to see if dropdowns with key stores are possible now.

@GregoryIvo GregoryIvo changed the title Wpa enterprise certificate support frontend feat(web2): Wpa enterprise EAP-TLS certificate support frontend Oct 6, 2023
@MMaiero MMaiero force-pushed the wpa-enterprise-certificate-support-frontend branch from bc29db3 to 2b57380 Compare October 10, 2023 07:37
@GregoryIvo GregoryIvo force-pushed the wpa-enterprise-certificate-support-frontend branch from 2b57380 to 67fa284 Compare October 10, 2023 13:26
@GregoryIvo
Copy link
Contributor Author

Almost ready for review:
Just need to add a default password value

@mattdibi
Copy link
Contributor

mattdibi commented Oct 12, 2023

Tested this at d4d9c2e in #4872. Looking good so far!

@GregoryIvo one question: do we really need two different fields for passing the client key if they are the same?

image

... or did I do something wrong?

@GregoryIvo
Copy link
Contributor Author

This is correct, and expected. I was thinking about that too but am torn because I like the potential flexibility

@mattdibi
Copy link
Contributor

This is correct, and expected. I was thinking about that too but am torn because I like the potential flexibility

As a user I find it confusing... Why should I set the same for both if I added it as a single Pub/Priv key pair? Also I have a hard time imagining a situation in which this flexibility could be taken advantage of? Can you explain to me a scenario where these two separated fields can be useful? 🤔

@mattdibi
Copy link
Contributor

Superseded by #4895

@mattdibi mattdibi closed this Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants