-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(linux.net): Add a Dhcp Server lease file for interface #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierantoniomerlino
force-pushed
the
dhcp_lease_files
branch
2 times, most recently
from
October 24, 2023 07:42
089a6a5
to
6034f7f
Compare
pierantoniomerlino
force-pushed
the
dhcp_lease_files
branch
from
October 30, 2023 10:43
f9a13ee
to
b02efd4
Compare
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
pierantoniomerlino
force-pushed
the
dhcp_lease_files
branch
from
October 30, 2023 14:33
deada42
to
ffb8250
Compare
Signed-off-by: pierantoniomerlino <[email protected]>
....kura.net.admin/src/main/java/org/eclipse/kura/net/admin/visitor/linux/DhcpConfigWriter.java
Show resolved
Hide resolved
....eclipse.kura.linux.net/src/main/java/org/eclipse/kura/linux/net/dhcp/DhcpServerManager.java
Outdated
Show resolved
Hide resolved
...eclipse.kura.web2/src/main/java/org/eclipse/kura/web/server/GwtNetworkServiceImplFacade.java
Show resolved
Hide resolved
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
marcellorinaldo
approved these changes
Oct 31, 2023
Signed-off-by: pierantoniomerlino <[email protected]>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a specific lease file for each network interface when using the DHCP server.
Description of the solution adopted: Currently if two DHCP servers are running in the system, the DHCP server instances will use the same default lease file in
/var/lib/dhcp/dhcpd.leases
. To avoid this, this PR use the same approach of the DHCP server configuration file and pid file that have a per interface file.The specific lease file is added in the configuration file for every supported DHCP server (dhcpd, udhcpd and dnsmasq).
Moreover, a limited refactoring is done in order to simply the creation of the configuration string for the tools used as DHCP servers. A set of converters from the
DhcpServerConfigIP
to String are implemented.Finally, the
DhcpLeaseTool
class has been updated to take into account the new lease files.