docs(nm): added documentation for vlan and mtu configuration #4919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdibi
reviewed
Oct 27, 2023
There was a problem hiding this comment.
LGTM
Only one thing: we think that the addition of the support for VLANs is so important that requires a dedicated page in the Network Configuration section on its own, like we did for "Network Failover" and "Wi-Fi 802.1x Configuration". Like this:
Obviously for now it will be a barebone page since we still don't have a UI, but will be updated in the future when we do.
The page should contain some basic info about what VLANs are, how Kura treats them, some further explaination of what parameters are required etc.
Do you think you can handle that?
|
Sure, but i'll need a few days :) |
|
@fdizazzo no problemo! 👍 |
|
... and it's done 😃 |
mattdibi
reviewed
Nov 8, 2023
mattdibi
reviewed
Nov 8, 2023
mattdibi
approved these changes
Nov 8, 2023
|
@fdizazzo thanks for your contribution 😄 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 8, 2023
* docs(nm): added documentation for vlan and mtu configuration * fix: Delete nohup.out * docs: vlan configuration details page * docs: fixed typos, added example for reactivation * docs: fixed typos and broken link in vlan configuration page * Update docs/gateway-configuration/vlan-configuration.md * Update docs/gateway-configuration/vlan-configuration.md --------- Co-authored-by: Mattia Dal Ben <[email protected]> (cherry picked from commit 7f6e7a7)
mattdibi
pushed a commit
that referenced
this pull request
Nov 8, 2023
…t docs-release-5.4] (#4958) docs(nm): added documentation for VLAN and MTU configuration (#4919) * docs(nm): added documentation for vlan and mtu configuration * fix: Delete nohup.out * docs: vlan configuration details page * docs: fixed typos, added example for reactivation * docs: fixed typos and broken link in vlan configuration page * Update docs/gateway-configuration/vlan-configuration.md * Update docs/gateway-configuration/vlan-configuration.md --------- Co-authored-by: Mattia Dal Ben <[email protected]> (cherry picked from commit 7f6e7a7) Co-authored-by: fdizazzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation for #4877 and #4816