feat(rest.packages.provider): add endpoint for Package Descriptor retrieval [backport release-5.4.0] #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rieval (#4934) * feat: add MarketplacePackageDescriptor.java * feat: add barebone getMarketplacePackageDescriptor method implementation WIP * feat: add getMarketplacePackageDescriptor to DeploymentAgentService interface * feat: add isEclipseMarketplaceUrl check WIP * style: fix variable name * feat: add quick&dirty descriptor check endpoint STILL WIP: we should at least have a dedicated request type instead of recycling InstallRequest * feat: return json object * debug: add debugging log * feat: actually perform check on input url * feat: add proper Kura version retrival * refactor: move instantiation * refactor: use proper exceptions * style: add copyright header * feat: use QueryParam for passing the URL to be checked * feat: provide equals and hashCode overrides * fix: do not log user-controlled data * fix: replace character class by the character itself * test: add unit tests for MarketplacePackageDescriptor * style: add copyright header * style: refactor into gerkhin style * refactor: move given/when/then methods in their sections * refactor: use the builder for gods sake * style: add forgotten about files * test: add DeploymentRestServiceUnitTest for marketplace descriptor * refactor: move URL checks outside DeploymentAgentService to allow for testing * test: update unit tests * refactor: move method into its section * test: add integration tests * fix: remove commented out code * test: add some more tests * test: add test case for failing getMarketplacePackageDescriptor call * docs: add Javadocs for DeploymentRestService * docs: add javadocs for DeploymentAgentService * test: add DeploymentAgentTest:getMarketplacePackageDescriptor tests (#11) * ci(debug): set envvar to run testcontainers with podman * refactor: user raw Mockserver instead of going through Testcontainers * refactor: remove unnecessary dependencies * ci: roll-back changes * test: use random free port * test: add null URL test * test: reset MockServer status after each test * feat: GET -> PUT * test: GET -> PUT * refactor(web2): modify UI so that it uses the newly introduced method * build: downgrade mockserver 5.15.0 -> 5.14.0 * build: I'm a dum dum * docs: add "since" annotation for newly introduced method * style: update copyright headers * chore: deployment agent service version bump to 1.1.0 * feat: add method for overriding SslManagerService used to establish connection * style: restore formatting * style: update copyright headers * style: update copyright header * build: switched to mockserver v 5.15.0 * docs: remove newly added test deps from NOTICE file
nicolatimeus
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4934