fix: wire record query unbind error #4983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MMaiero <[email protected]>
Signed-off-by: MMaiero <[email protected]>
MMaiero
changed the title
nicolatimeus
approved these changes
Nov 15, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2023
* fix: WireRecordQuery unbind error on deactivate Signed-off-by: MMaiero <[email protected]> * fix: added missing deactivate in store query Signed-off-by: MMaiero <[email protected]> --------- Signed-off-by: MMaiero <[email protected]> (cherry picked from commit 23e9d92)
MMaiero
added a commit
that referenced
this pull request
Nov 15, 2023
fix: wire record query unbind error (#4983) * fix: WireRecordQuery unbind error on deactivate Signed-off-by: MMaiero <[email protected]> * fix: added missing deactivate in store query Signed-off-by: MMaiero <[email protected]> --------- Signed-off-by: MMaiero <[email protected]> (cherry picked from commit 23e9d92) Co-authored-by: Matteo Maiero <[email protected]>
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR. [e.g. Added
nullcheck onobjectto avoidNullPointerException]Description of the solution adopted: Removed not needed references in definition to unbind methods. Added missing deactivate method.
Screenshots: N/A
Manual Tests: Performed build and installation and verified that the previously reported errors are not anymore present
Any side note on the changes made: No