Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed web ui access for identity with limited permissions #4988

Merged

Conversation

nicolatimeus
Copy link
Contributor

@nicolatimeus nicolatimeus commented Nov 16, 2023

Currently, after creating a new identity and assigning it a set of specific permissions Kura starts to flicker with an error dialog on screen (see video below).

Screen.Recording.2023-11-17.at.08.56.19.mov

This was due to the Web UI trying to perform some calls (trying to establish if the profile was using the new networking) even if the current identity does not have the required permissions, resulting in 403 errors.

This PR fixes the issue

@mattdibi
Copy link
Contributor

mattdibi commented Nov 17, 2023

Test performed

On develop branch

Created an identity testIdentity with permission "kura.device".

image

This results in the behaviour of the video below.

Screen.Recording.2023-11-17.at.08.56.19.mov

On the fix branch

The identity with the same permissions results in no error in the UI.

image

@mattdibi mattdibi merged commit 5a5a9b3 into eclipse-kura:develop Nov 17, 2023
8 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
MMaiero pushed a commit that referenced this pull request Nov 17, 2023
…ort release-5.4.0] (#4989)

fix: Fixed web ui access for identity with limited permissions (#4988)

Signed-off-by: Nicola Timeus <[email protected]>
(cherry picked from commit 5a5a9b3)

Co-authored-by: nicolatimeus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants