Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest.network.configuration.provider): Added factoryComponents APIs #4994

Merged

Conversation

sfiorani
Copy link
Contributor

This PR adds the factoryComponents apis to the RestNetworkConfiguration provider.

Related Issue:

Description of the solution adopted:

Screenshots:

Manual Tests:

Any side note on the changes made:

Signed-off-by: SimoneFiorani <[email protected]>
@sfiorani sfiorani marked this pull request as ready for review November 17, 2023 13:44
@MMaiero MMaiero requested a review from nicolatimeus November 17, 2023 13:50
Copy link
Contributor

@nicolatimeus nicolatimeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing due to code duplication, which is difficult to solve without a large refactor. Merging with the aim of refactoring the code later on.

@nicolatimeus nicolatimeus merged commit d94ccbf into eclipse-kura:develop Nov 17, 2023
2 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 17, 2023
…Is (#4994)

* Added factoryComponents apis

Signed-off-by: SimoneFiorani <[email protected]>

* Added check on possible null entries in non-generic profiles

Signed-off-by: SimoneFiorani <[email protected]>

* Added test for factoryPids

Signed-off-by: SimoneFiorani <[email protected]>

---------

Signed-off-by: SimoneFiorani <[email protected]>
(cherry picked from commit d94ccbf)
MMaiero pushed a commit that referenced this pull request Nov 17, 2023
…Is [backport release-5.4.0] (#4998)

feat(rest.network.configuration.provider): Added factoryComponents APIs (#4994)

* Added factoryComponents apis

Signed-off-by: SimoneFiorani <[email protected]>

* Added check on possible null entries in non-generic profiles

Signed-off-by: SimoneFiorani <[email protected]>

* Added test for factoryPids

Signed-off-by: SimoneFiorani <[email protected]>

---------

Signed-off-by: SimoneFiorani <[email protected]>
(cherry picked from commit d94ccbf)

Co-authored-by: sfiorani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants