fix: enforced mandatory UserAdmin static reference on rest bundles that create permissions #5014
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at create permissions Signed-off-by: Marcello Martina <[email protected]>
nicolatimeus
approved these changes
Nov 22, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 22, 2023
…at create permissions (#5014) Signed-off-by: Marcello Martina <[email protected]> (cherry picked from commit e7b8bc0)
This was referenced Nov 23, 2023
salvatore-coppola
pushed a commit
that referenced
this pull request
Nov 23, 2023
…at create permissions [backport release-5.4.0] (#5015) fix: enforced mandatory UserAdmin static reference on rest bundles that create permissions (#5014) Signed-off-by: Marcello Martina <[email protected]> (cherry picked from commit e7b8bc0) Co-authored-by: Marcello Rinaldo Martina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, REST request handler bundles that require a particular
kura.permissionrole and creates it on binding theUserAdminreference, will now have theUserAdminreference static and mandatory.This avoids situations where the role is not present on the snapshot and the bundle comes up before the
UserAdmin. In such case, the permission will never be created and the bundle remain unutilizable.Related Issue: N/A.
Description of the solution adopted: N/A.
Screenshots: N/A.
Manual Tests: N/A.
Any side note on the changes made: N/A.