fix: unhide keystore field and add error correction that prevents ca-cert being filled and keystore being null #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cert being filled and keystore being null
|
@marcellorinaldo kindly review this please |
|
@MMaiero Can we tag this for rc5 too? |
marcellorinaldo
approved these changes
Nov 29, 2023
marcellorinaldo
pushed a commit
that referenced
this pull request
Nov 29, 2023
…cert being filled and keystore being null [backport release-5.4.0] (#5032) fix: unhide keystore field and add error correction that prevents ca-cert being filled and keystore being null (#5030) (cherry picked from commit aaf6d5c) Co-authored-by: G_Ivo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where you are unable to add a keystore pid when trying to use a optional ca-cert for eap-ttls and eap-peap.
Brief description of the PR. [e.g. Added
nullcheck onobjectto avoidNullPointerException]Related Issue: This PR fixes/closes {issue number}
Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped
Screenshots:
Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review
Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]