fix: 802.1x tab displaying and refresh #5055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MMaiero <[email protected]>
Disabled parameters initializationAfter first opening the tab the field are disabled as expected Before this PR:
After this PR:
Note: both screenshot were taken upon first opening the 802.1x tab in Kura 802.1x tab enabling802.1x tab is correctly enabled when either one (or both) between ipv4 and ipv6 is enabled and the wireless security is set to WPA Enterprise. |
mattdibi
reviewed
Dec 12, 2023
Comment on lines
356
to
360
| logger.info("update"); | ||
| setValues(); | ||
| refreshForm(); | ||
| this.netTabs.updateTabs(); | ||
| logger.info("update... done"); |
There was a problem hiding this comment.
Only thing here is... is this log entry worth the info level or would it be better suited for the debug level?
Suggested change
| logger.info("update"); | |
| setValues(); | |
| refreshForm(); | |
| this.netTabs.updateTabs(); | |
| logger.info("update... done"); | |
| logger.debug("update"); | |
| setValues(); | |
| refreshForm(); | |
| this.netTabs.updateTabs(); | |
| logger.debug("update... done"); |
mattdibi
reviewed
Dec 12, 2023
| @@ -370,6 +382,7 @@ private void refreshForm() { | |||
| } | |||
|
|
|||
| private void reset() { | |||
| logger.info("reset"); | |||
There was a problem hiding this comment.
Same here
Suggested change
| logger.info("reset"); | |
| logger.debug("reset"); |
mattdibi
reviewed
Dec 12, 2023
| @@ -390,6 +403,8 @@ private void reset() { | |||
| this.keystorePid.setValue(""); | |||
| this.caCertName.setValue(""); | |||
| this.publicPrivateKeyPairName.setValue(""); | |||
| update(); | |||
| logger.info("reset... done"); | |||
There was a problem hiding this comment.
... and here
Suggested change
| logger.info("reset... done"); | |
| logger.debug("reset... done"); |
mattdibi
approved these changes
Dec 12, 2023
Signed-off-by: MMaiero <[email protected]>
|
@mattdibi I have removed the logs. |
mattdibi
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR. [e.g. Added
nullcheck onobjectto avoidNullPointerException]Related Issue: N/A
Description of the solution adopted: Another attempt to improve the availability and refresh for the 802.1x tab in the wireless section
Screenshots: N/A
Manual Tests: Tested with ipv4 and ipv6 disabled as well enabling each of them. All the tests done first without and then with the selection of the enterprise security.
Any side note on the changes made: N/A