Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update development environment setup guide #5060

Merged
merged 17 commits into from
Dec 14, 2023

Conversation

mattdibi
Copy link
Contributor

@mattdibi mattdibi commented Dec 12, 2023

This PR updates the Development Environment Setup guide. In addition to that I tried to clearly distinguish between the "User" installation (i.e. Kura Workspace setup which only installs the APIs and the examples) and the "Developer" installation (i.e. Development Environment Setup).

I set the Oomph installer as our preferred installation method since it sets all the required plugins and formatters that we expect.

@MMaiero I'm still a little confused about our documentation: the section is named "Java Application Development" and seems to be geared towards the development of application running inside Kura not Kura itself but, in the current "Development Environment Setup" guide, we have a section dedicated to Oomph which can be used to setup the environment for Kura itself. Not to mention the contributing section.

Should we have a dedicated section for the dev env setup for contributing to Kura? Should this be in the Wiki?

Update: after a brief offline discussion we decided to keep the guide here to benefit from the versioning provided by MkDocs. We also decided to clearly distinguish between core development environment setup and add-on development environment setup.

@mattdibi mattdibi marked this pull request as draft December 13, 2023 07:23
@mattdibi mattdibi marked this pull request as ready for review December 13, 2023 08:37
Copy link
Contributor

@MMaiero MMaiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still few "kura" around that need to be fixed. I marked in the comments only a few of them

@mattdibi mattdibi merged commit 1de976d into docs-develop Dec 14, 2023
2 checks passed
@mattdibi mattdibi deleted the feat/update_dev_env_setup_guide branch December 14, 2023 10:46
Copy link
Contributor

The backport to docs-release-5.4 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-docs-release-5.4 docs-release-5.4
# Navigate to the new working tree
cd .worktrees/backport-docs-release-5.4
# Create a new branch
git switch --create backport-5060-to-docs-release-5.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1de976d1bdc1f490f3282d06c363d702b31d9c24
# Push it to GitHub
git push --set-upstream origin backport-5060-to-docs-release-5.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-docs-release-5.4

Then, create a pull request where the base branch is docs-release-5.4 and the compare/head branch is backport-5060-to-docs-release-5.4.

mattdibi added a commit that referenced this pull request Dec 14, 2023
* docs: add first draft for new DevEnv setup guide

* refactor: removed old images, moved images in correct folder

* refactor: rename images

* refactor: rename images

* refactor: restore old guide

* refactor: clear distinction between "User" and "Developer" develpment environment

* refactor: some wording

* refactor: remove unnecessary files

* refactor: remove reference to Oomph installer that we don't know if works

* feat: clearly distinguis core development from add-on develpment

* style: Kura -> Eclipse Kura

* fix: missing comma

* fix: missing comma

* style: missing "the"

* docs: Kura -> Eclipse Kura

Co-authored-by: Matteo Maiero <[email protected]>

* docs: Kura -> Eclipse Kura

Co-authored-by: Matteo Maiero <[email protected]>

* docs: Kura -> Eclipse Kura

---------

Co-authored-by: Matteo Maiero <[email protected]>
MMaiero added a commit that referenced this pull request Dec 14, 2023
…se-5.4] (#5069)

docs: update development environment setup guide (#5060)

* docs: add first draft for new DevEnv setup guide

* refactor: removed old images, moved images in correct folder

* refactor: rename images

* refactor: rename images

* refactor: restore old guide

* refactor: clear distinction between "User" and "Developer" develpment environment

* refactor: some wording

* refactor: remove unnecessary files

* refactor: remove reference to Oomph installer that we don't know if works

* feat: clearly distinguis core development from add-on develpment

* style: Kura -> Eclipse Kura

* fix: missing comma

* fix: missing comma

* style: missing "the"

* docs: Kura -> Eclipse Kura



* docs: Kura -> Eclipse Kura



* docs: Kura -> Eclipse Kura

---------

Co-authored-by: Matteo Maiero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants