Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sparkplug): added Sparkplug B Protobuf Payload support and utility classes #5072

Merged

Conversation

marcellorinaldo
Copy link
Contributor

@marcellorinaldo marcellorinaldo commented Dec 18, 2023

This PR adds a Sparkplug topics utility and a Builder for encoding MQTT payload in Sparkplug B Protobuf format.

Dependencies:

Related Issue: N/A.

Description of the solution adopted:

  • Added Builder for encoding metrics in Sparkplug B format and convert Kura TypedValues into compatible format
  • Added topic utility
  • Added tests

Screenshots: N/A.

Manual Tests: N/A.

Any side note on the changes made: N/A.

@marcellorinaldo marcellorinaldo marked this pull request as ready for review December 20, 2023 09:16
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
Signed-off-by: Marcello Martina <[email protected]>
@marcellorinaldo
Copy link
Contributor Author

marcellorinaldo commented Dec 21, 2023

Licensing should be in order. The used protobuf definition file (.proto) is licensed under EPL 2.0 and is not modified in this contribution.

Same principle has been applied to PR #3810, where the contribution included a protobuf definition from a third party.

@MMaiero MMaiero merged commit 4b06742 into eclipse-kura:develop Dec 22, 2023
4 checks passed
@MMaiero MMaiero deleted the sparkplug-protobuf-payload branch December 22, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants