Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Network Advanced tab positioning #5106

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

MMaiero
Copy link
Contributor

@MMaiero MMaiero commented Jan 24, 2024

Moved the advanced tab before the hardware one.
This would simplify the user interaction as it is expected to be less opened than the other tabs in networking.

@MMaiero MMaiero requested a review from mattdibi January 24, 2024 14:28
@MMaiero MMaiero changed the title fix: Network Advanced position fix: Network Advanced tab positioning Jan 24, 2024
Copy link
Contributor

@mattdibi mattdibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working on RPi ARM64

image

LGTM 👍

@mattdibi mattdibi merged commit d53ec83 into develop Jan 24, 2024
8 checks passed
@mattdibi mattdibi deleted the fix_network_advanced_position branch January 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants