feat: Added support for emitting connection errors in WireAsset #5479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolatimeus
force-pushed
the
feat_asset-error
branch
from
f0da7f7 to
afc78f3
Compare
Signed-off-by: Nicola Timeus <[email protected]>
Signed-off-by: Nicola Timeus <[email protected]>
pierantoniomerlino
force-pushed
the
feat_asset-error
branch
from
853420c to
6a1a025
Compare
pierantoniomerlino
approved these changes
Oct 30, 2024
|
Succesfully tested with a RPI and the Modbus Driver. |
eclipse-kura-bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
* feat: Added support for emitting connection errors in WireAsset Signed-off-by: Nicola Timeus <[email protected]> * Added test for null error message Signed-off-by: Nicola Timeus <[email protected]> --------- Signed-off-by: Nicola Timeus <[email protected]> (cherry picked from commit fecabd4)
nicolatimeus
added a commit
that referenced
this pull request
Oct 30, 2024
…port release-5.6.0] (#5494) feat: Added support for emitting connection errors in WireAsset (#5479) * feat: Added support for emitting connection errors in WireAsset Signed-off-by: Nicola Timeus <[email protected]> * Added test for null error message Signed-off-by: Nicola Timeus <[email protected]> --------- Signed-off-by: Nicola Timeus <[email protected]> (cherry picked from commit fecabd4) Co-authored-by: nicolatimeus <[email protected]>
MMaiero
pushed a commit
that referenced
this pull request
Dec 20, 2024
* feat: Added support for emitting connection errors in WireAsset Signed-off-by: Nicola Timeus <[email protected]> * Added test for null error message Signed-off-by: Nicola Timeus <[email protected]> --------- Signed-off-by: Nicola Timeus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR. [e.g. Added
nullcheck onobjectto avoidNullPointerException]Adds support for emitting an envelope in case of ConnectionException during read operations in WireAsset. The envelope will contain a property named
assetErrorcontaining the error message associated with the exception and a timestamp.