fix(distrib): Updated installer script to write all interface names to snapshot file #5522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <[email protected]>
mattdibi
reviewed
Nov 7, 2024
Comment on lines
+93
to
94
| for i, eth_name in enumerate(eth_names): | ||
| snapshot_content = snapshot_content.replace('ETH_INTERFACE_' + str(i), eth_name) |
There was a problem hiding this comment.
I would try to keep this more explicit since, in the future, we don't know whether the template will change. Therefore I would suggest something like:
Suggested change
| for i, eth_name in enumerate(eth_names): | |
| snapshot_content = snapshot_content.replace('ETH_INTERFACE_' + str(i), eth_name) | |
| for i, eth_name in enumerate(eth_names): | |
| if i < 2: # only replace the template content with the first two network interfaces | |
| snapshot_content = snapshot_content.replace('ETH_INTERFACE_' + str(i), eth_name) |
Comment on lines
+98
to
99
| for i, wlan_name in enumerate(wlan_names): | ||
| snapshot_content = snapshot_content.replace('WIFI_INTERFACE_' + str(i), wlan_name) |
There was a problem hiding this comment.
Same thing here:
Suggested change
| for i, wlan_name in enumerate(wlan_names): | |
| snapshot_content = snapshot_content.replace('WIFI_INTERFACE_' + str(i), wlan_name) | |
| for i, wlan_name in enumerate(wlan_names): | |
| if i < 1: # only replace the template content with the first network interface | |
| snapshot_content = snapshot_content.replace('WIFI_INTERFACE_' + str(i), wlan_name) |
mattdibi
approved these changes
Nov 7, 2024
eclipse-kura-bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
…o snapshot file (#5522) Updated installer script to write all interface names to snapshot file Signed-off-by: pierantoniomerlino <[email protected]> (cherry picked from commit c2ea2ff)
MMaiero
pushed a commit
that referenced
this pull request
Nov 8, 2024
…o snapshot file [backport release-5.6.0] (#5528) fix(distrib): Updated installer script to write all interface names to snapshot file (#5522) Updated installer script to write all interface names to snapshot file Signed-off-by: pierantoniomerlino <[email protected]> (cherry picked from commit c2ea2ff) Co-authored-by: Pierantonio Merlino <[email protected]>
pierantoniomerlino
pushed a commit
that referenced
this pull request
Nov 11, 2024
eclipse-kura-bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
MMaiero
pushed a commit
that referenced
this pull request
Dec 20, 2024
…o snapshot file (#5522) Updated installer script to write all interface names to snapshot file Signed-off-by: pierantoniomerlino <[email protected]>
MMaiero
pushed a commit
that referenced
this pull request
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the installer script to add all the interface names detected on the system during installation to the
net.interfacesproperty of the snapshot_0 file.