fix: fixed nmea position unit of measurement #5543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
Signed-off-by: SimoneFiorani <[email protected]>
| this.nrSatellites, this.mDOP, this.mPDOP, this.mHDOP, this.mVDOP, this.m3Dfix, this.validFix, | ||
| this.latitudeHemisphere, this.longitudeHemisphere); | ||
| return new NmeaPosition(this.latitudeDegrees, this.longitudeDegrees, this.altitudeMeters, | ||
| this.speedMetersPerSecond * MS_TO_KMH, this.trackDegrees, this.fixQuality, this.nrSatellites, this.mDOP, |
There was a problem hiding this comment.
This conversion to KMH should be removed right?
Signed-off-by: SimoneFiorani <[email protected]>
nicolatimeus
approved these changes
Nov 12, 2024
|
Forcing merge. The PR will be validated in the Kura 5.6.0 QA |
eclipse-kura-bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
* fix: fixed nmea position unit of measurement Signed-off-by: SimoneFiorani <[email protected]> * refactor: improved field names Signed-off-by: SimoneFiorani <[email protected]> * refactor: changed fields names Signed-off-by: SimoneFiorani <[email protected]> * fix: remained unnecessary conversion Signed-off-by: SimoneFiorani <[email protected]> --------- Signed-off-by: SimoneFiorani <[email protected]> (cherry picked from commit d60b6b8)
MMaiero
pushed a commit
that referenced
this pull request
Nov 13, 2024
…#5549) fix: fixed nmea position unit of measurement (#5543) * fix: fixed nmea position unit of measurement Signed-off-by: SimoneFiorani <[email protected]> * refactor: improved field names Signed-off-by: SimoneFiorani <[email protected]> * refactor: changed fields names Signed-off-by: SimoneFiorani <[email protected]> * fix: remained unnecessary conversion Signed-off-by: SimoneFiorani <[email protected]> --------- Signed-off-by: SimoneFiorani <[email protected]> (cherry picked from commit d60b6b8) Co-authored-by: sfiorani <[email protected]>
MMaiero
pushed a commit
that referenced
this pull request
Dec 20, 2024
* fix: fixed nmea position unit of measurement Signed-off-by: SimoneFiorani <[email protected]> * refactor: improved field names Signed-off-by: SimoneFiorani <[email protected]> * refactor: changed fields names Signed-off-by: SimoneFiorani <[email protected]> * fix: remained unnecessary conversion Signed-off-by: SimoneFiorani <[email protected]> --------- Signed-off-by: SimoneFiorani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the unit measurment of latitude, longitude, track and speed for the MM Position Provider. The first three values were reported in radians instead of degrees, and the last one in meter per seconds instead of km per hour.
Related Issue: This PR fixes/closes {issue number}
Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped
Screenshots: If applicable, add screenshots to help explain your solution
Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review
Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]