feat: Hide WPA3 feature based on Kura property #5607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierantoniomerlino
force-pushed
the
wpa3_capability_hide_property
branch
from
f35da42 to
b59ea8a
Compare
pierantoniomerlino
changed the title
| @@ -152,6 +158,7 @@ interface TabWirelessUiUiBinder extends UiBinder<Widget, TabWirelessUi> { | |||
| private final NetworkTabsUi netTabs; | |||
| private final ListDataProvider<GwtWifiHotspotEntry> ssidDataProvider = new ListDataProvider<>(); | |||
| private final SingleSelectionModel<GwtWifiHotspotEntry> ssidSelectionModel = new SingleSelectionModel<>(); | |||
| // private boolean isWPA3WifiSecuritySupported; | |||
There was a problem hiding this comment.
Please remove this commented code
| @@ -375,4 +375,10 @@ public void shouldGetDefaultLogManagerProperty() { | |||
| assertFalse(systemService.getDefaultLogManager().isPresent()); | |||
| } | |||
|
|
|||
| @TestTarget(targetPlatforms = { TestTarget.PLATFORM_ALL }) | |||
There was a problem hiding this comment.
Please update copyright header
| @@ -195,9 +195,9 @@ public ArrayList<GwtGroupedNVPair> findSystemProperties(GwtXSRFToken xsrfToken) | |||
| // kura properties | |||
| SystemService systemService = ServiceLocator.getInstance().getService(SystemService.class); | |||
| Properties kuraProps = systemService.getProperties(); | |||
| SortedSet kuraKeys = new TreeSet(kuraProps.keySet()); | |||
| SortedSet kuraKeys = new TreeSet(kuraProps.stringPropertyNames()); | |||
There was a problem hiding this comment.
Please update copyright header
| @@ -25,4 +25,5 @@ | |||
| <reference bind="setDnsServerService" cardinality="1..1" interface="org.eclipse.kura.internal.linux.net.dns.DnsServerService" name="DNSService" policy="static" /> | |||
| <reference name="CryptoService" interface="org.eclipse.kura.crypto.CryptoService" bind="setCryptoService" unbind="unsetCryptoService" cardinality="1..1" policy="static"/> | |||
| <reference name="KeystoreService" interface="org.eclipse.kura.security.keystore.KeystoreService" bind="setKeystoreService" unbind="unsetKeystoreService" cardinality="0..n" policy="dynamic"/> | |||
| <reference bind="setSystemService" cardinality="1..1" interface="org.eclipse.kura.system.SystemService" name="SystemService" policy="static"/> | |||
There was a problem hiding this comment.
Please update copyright header
pierantoniomerlino
force-pushed
the
wpa3_capability_hide_property
branch
from
547db70 to
78ff6aa
Compare
|
Should we also filter away/prohibit connection to the networks that use WPA3 from the scan results in web ui when in station mode? |
|
@nicolatimeus I was convinced to have already add that filter... but it seems that I lost that modification in some rebase. I'll add it. |
nicolatimeus
approved these changes
Dec 16, 2024
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
Signed-off-by: pierantoniomerlino <[email protected]>
MMaiero
force-pushed
the
wpa3_capability_hide_property
branch
from
107760b to
acee329
Compare
MMaiero
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Hide WPA3 feature based on property Signed-off-by: pierantoniomerlino <[email protected]> * Updated copyright Signed-off-by: pierantoniomerlino <[email protected]> * Removed commented line; updated copyright headers Signed-off-by: pierantoniomerlino <[email protected]> * Added filtering of WPA3 on hotspot scans Signed-off-by: pierantoniomerlino <[email protected]> --------- Signed-off-by: pierantoniomerlino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a way to disable the new WPA3 feature based on a specific Kura property.
Related Issue: This PR fixes/closes N/A
Description of the solution adopted: The #5586 added the (experimental) support for WPA3 Wifi Security. This PR adds a Kura property (
kura.wpa3.wifi.security.enable) that hides/shows the WPA3 entries on the Wireless tab of the webUI. Moreover, the same property inhibits/allows the application of a network configuration containing WPA3 related properties to the framework.The default behavior is to hide the feature.