Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update readme logo to point to logo on new website #5619

Closed
wants to merge 1 commit into from

Conversation

GregoryIvo
Copy link
Contributor

@GregoryIvo GregoryIvo commented Dec 13, 2024

Simply fixed the link in the HTML tag, click preview and see for yourself! 😉

image

Maybe we have a higher quality logo somewhere else?

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

Brief description of the PR. [e.g. Added null check on object to avoid NullPointerException]

Related Issue: This PR fixes/closes {issue number}

Description of the solution adopted: A more detailed description of the changes made to solve/close one or more issues. If the PR is simple and easy to understand this section can be skipped

Screenshots: If applicable, add screenshots to help explain your solution

Manual Tests: Optional description of the tests performed to check correct functioning of changes, useful for an efficient review

Any side note on the changes made: Description of any other change that has been made, which is not directly linked to the issue resolution [e.g. Code clean up/Sonar issue resolution]

@GregoryIvo GregoryIvo requested a review from mattdibi December 13, 2024 16:55
@GregoryIvo
Copy link
Contributor Author

@mattdibi sorry I forgot to add tests

@GregoryIvo
Copy link
Contributor Author

interesting note, the logo in the our docs are missing the "TM". 🤔

image

@mattdibi
Copy link
Contributor

Too slow #5618 😎

P.s. Jokes aside: thank you for contributing the fix. This is really appreciated 🙏

@mattdibi mattdibi closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants