Improve readability

eclipse-langium · Sep 30, 2024 · 8df5467 · 8df5467
1 parent 04e6644
commit 8df5467
Showing 1 changed file with 12 additions and 8 deletions.
diff --git a/packages/langium/src/utils/caching.ts b/packages/langium/src/utils/caching.ts
@@ -157,18 +157,20 @@ export class DocumentCache<K, V> extends ContextCache<URI | string, K, V, string
      */
     constructor(sharedServices: LangiumSharedCoreServices, state?: DocumentState) {
         super(uri => uri.toString());
+        let disposable: Disposable;
         if (state) {
-            this.onDispose(sharedServices.workspace.DocumentBuilder.onDocumentPhase(state, document => {
+            disposable = sharedServices.workspace.DocumentBuilder.onDocumentPhase(state, document => {
                 this.clear(document.uri.toString());
-            }));
+            });
         } else {
-            this.onDispose(sharedServices.workspace.DocumentBuilder.onUpdate((changed, deleted) => {
+            disposable = sharedServices.workspace.DocumentBuilder.onUpdate((changed, deleted) => {
                 const allUris = changed.concat(deleted);
                 for (const uri of allUris) {
                     this.clear(uri);
                 }
-            }));
+            });
         }
+        this.toDispose.push(disposable);
     }
 }
 
@@ -187,14 +189,16 @@ export class WorkspaceCache<K, V> extends SimpleCache<K, V> {
      */
     constructor(sharedServices: LangiumSharedCoreServices, state?: DocumentState) {
         super();
+        let disposable: Disposable;
         if (state) {
-            this.onDispose(sharedServices.workspace.DocumentBuilder.onBuildPhase(state, () => {
+            disposable = sharedServices.workspace.DocumentBuilder.onBuildPhase(state, () => {
                 this.clear();
-            }));
+            });
         } else {
-            this.onDispose(sharedServices.workspace.DocumentBuilder.onUpdate(() => {
+            disposable = sharedServices.workspace.DocumentBuilder.onUpdate(() => {
                 this.clear();
-            }));
+            });
         }
+        this.toDispose.push(disposable);
     }
 }