Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make keyword filtering in completion provider configurable #1204

Merged
merged 1 commit into from
Sep 27, 2023
Merged

feat: make keyword filtering in completion provider configurable #1204

merged 1 commit into from
Sep 27, 2023

Conversation

cdietrich
Copy link
Contributor

No description provided.

@cdietrich cdietrich force-pushed the cd/isKeywordWorthyToPropose branch from 232ec74 to 3b0ca3e Compare September 27, 2023 13:11
msujew
msujew reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it: I've noticed that the filterCrossReference method doesn't accept a CompletionContext as a parameter. In it's current state, the method is kind of useless. Do you mind adding that as well?

packages/langium/src/lsp/completion/completion-provider.ts Outdated Show resolved Hide resolved
@msujew msujew added the completion Completion related issue label Sep 27, 2023
@cdietrich cdietrich force-pushed the cd/isKeywordWorthyToPropose branch from 3b0ca3e to 50bb812 Compare September 27, 2023 13:38
@cdietrich
Copy link
Contributor Author

adapted both methods

@cdietrich cdietrich force-pushed the cd/isKeywordWorthyToPropose branch from 50bb812 to 6a0f51a Compare September 27, 2023 13:40
msujew
msujew approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks 👍

@msujew msujew merged commit 9f4ec36 into eclipse-langium:main Sep 27, 2023
3 checks passed
@cdietrich
Copy link
Contributor Author

@spoenemann got a mail about the naming, but cannot find the comment

@cdietrich cdietrich deleted the cd/isKeywordWorthyToPropose branch September 29, 2023 14:27
@msujew msujew added this to the v2.1.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
completion Completion related issue
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cdietrich @msujew