Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set diagram server manager fields to protected #1211

Merged
merged 1 commit into from
Sep 29, 2023
Merged

set diagram server manager fields to protected #1211

merged 1 commit into from
Sep 29, 2023

Conversation

Rtulpe
Copy link
Contributor

@Rtulpe Rtulpe commented Sep 28, 2023

It does not make sense to have changedUris and outdatedDocuments fields as private, since if I want to extend the default class and change the behavior of lets say documentsUpdated() method, I have to re-implement everything.

@msujew msujew requested a review from spoenemann September 28, 2023 20:08
spoenemann
spoenemann approved these changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spoenemann spoenemann merged commit 3f6332a into eclipse-langium:main Sep 29, 2023
3 checks passed
@spoenemann spoenemann added this to the v2.1.0 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoenemann spoenemann spoenemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Rtulpe @spoenemann