Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat lines with only comment symbols as empty in JSDoc comments #1241

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Treat lines with only comment symbols as empty in JSDoc comments #1241

merged 2 commits into from
Oct 26, 2023

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Oct 24, 2023 •
edited
Loading

Previously, lines that only contained a (line) comment symbol did not trigger a new Markdown paragraph:

image

This PR adjusts this behavior, so a new paragraph gets created:

image

@lars-reimann lars-reimann marked this pull request as ready for review October 24, 2023 16:25
msujew
msujew approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I don't know how I missed that during testing 👍

@msujew msujew added the polish Some feature needs improvement label Oct 26, 2023
@msujew msujew merged commit aacb31d into eclipse-langium:main Oct 26, 2023
@msujew msujew added this to the v2.1.0 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
polish Some feature needs improvement
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lars-reimann @msujew