-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API docs #1697
Merged
Merged
API docs #1697
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
de7224f
Install and configure typedoc
aabounegm 5cd2c75
Fix some invalid JSDoc tags
aabounegm c684a74
Fix JSDoc to correspond to function signatures
aabounegm 17636a5
Replace comment with `satisfies` for better typing
aabounegm b164775
Fix typo in documentation comment
aabounegm 0daa393
Add workflow to build & deploy API docs on release
aabounegm e21044a
Use src tsconfig for API doc generation
aabounegm 34f851b
Customize module names to correspond to exports
aabounegm 58770a8
Add "remark" markers back instead of the tag
aabounegm 7b22f04
Clarify where DiagnosticSeverity is defined
aabounegm e2e2947
Separate docs build & deploy to another workflow
aabounegm 4b7d273
Use the remarks block tag for remarks
aabounegm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,7 @@ | |
.vscode-test/ | ||
coverage/ | ||
dist/ | ||
docs/ | ||
lib/ | ||
out/ | ||
node_modules/ | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if we want to constrain the publish job like this. We didn't need it before, and I think we may want to run this under different circumstances than this constraint would allow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we didn't have any other trigger before, but now I added the
workflow_dispatch
trigger to allow updating the docs manually even before a release. Now that I think about it, I'm not sure if this would actually ever be usedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, yeah I'm still not sure about this one. @msujew thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes more sense to have a separate
workflow_dispatch
job for the API docs publishing - right now, the release publishing process is broken due to expired credentials.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By "separate job", do you mean an entirely separate .yml file or just the additional trigger here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A separate yml file :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done