Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added failOnParseErrors option to validationHelper #1699

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

cdietrich
Copy link
Contributor

No description provided.

@cdietrich
Copy link
Contributor Author

cdietrich commented Sep 25, 2024

question: does anybody know why we put the code here

data: {
      code: DocumentValidator.ParsingError,
    }

and not into

code at top level (too) see processParsingErrors

@spoenemann
Copy link
Contributor

question: does anybody know why we put the code here and not into code at top level (too) see processParsingErrors

Because the code is meant to be user-facing information, like an error code that they can look up in the user manual of a compiler. We want to use that only internally, so we moved it into data (#1128).

@cdietrich
Copy link
Contributor Author

my committer paperwork is still stuck somewhere ....

@spoenemann spoenemann merged commit 8faa4b8 into eclipse-langium:main Sep 25, 2024
4 checks passed
@spoenemann spoenemann added this to the v3.3.0 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants