Add normalizing notebook documents service #1743
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #1660. Since the
NotebookDocuments
class exported byvscode-languageserver
is quite specific in what it accepts as aTextDocuments
instance (only instances of the class exported byvscode-languageserver
), adopters of Langium, can no longer plug Langium'sTextDocuments
service in there.However, the
NotebookDocuments
implementation ofvscode-languageserver
had the same URI encoding issues asTextDocuments
anyway, and so we need to roll our own. This newNormalizingNotebookDocuments
is now a default service of the shared LSP services and can be accessed by all Langium adopters.