Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalizing notebook documents service #1743

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msujew
Copy link
Member

@msujew msujew commented Nov 6, 2024

This is a continuation of #1660. Since the NotebookDocuments class exported by vscode-languageserver is quite specific in what it accepts as a TextDocuments instance (only instances of the class exported by vscode-languageserver), adopters of Langium, can no longer plug Langium's TextDocuments service in there.

However, the NotebookDocuments implementation of vscode-languageserver had the same URI encoding issues as TextDocuments anyway, and so we need to roll our own. This new NormalizingNotebookDocuments is now a default service of the shared LSP services and can be accessed by all Langium adopters.

@msujew msujew added polish Some feature needs improvement LSP Language Server Protocol integration labels Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP Language Server Protocol integration polish Some feature needs improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant