langium: follow-up on #972 contributing convenience type defs for cross-ref property distinction #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sailingKieler
commented
Dec 5, 2024
sailingKieler
commented
- fixed a nasty bug in internal type 'ExtractKeysOfValueType' by adding '-?' to the result object key list
- improved documentation
- contributed a bunch of tests in 'syntax-tree.test.ts' which is effectively tested during the TypeScript compilation: test failures occur as compilation errors
sailingKieler
force-pushed
the
cs/cross-ref-distinction
branch
from
b661ab3 to
d622fa2
Compare
msujew
reviewed
Dec 12, 2024
There was a problem hiding this comment.
@sailingKieler As discussed yesterday during the dev-meeting, there actually is a way to explicitly test types by invoking the TypeScript compiler. This is done by vitest (see type testing guide) when renaming the file to *.test-d.ts.
sailingKieler
force-pushed
the
cs/cross-ref-distinction
branch
from
d622fa2 to
67c147e
Compare
…ss-ref properties distinction * fixed a nasty bug in internal type 'ExtractKeysOfValueType' by adding '-?' to the result object key list * improved documentation * contributed a bunch of tests in 'syntax-tree.test.ts' which is effectively tested during the TypeScript compilation: test failures occur as compilation errors
sailingKieler
force-pushed
the
cs/cross-ref-distinction
branch
from
67c147e to
c8c441b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.