Support inactive regions #845
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this feature is needed for a clangd protocol extension. See this cdt-lsp issue eclipse-cdt/cdt-lsp#299 and this clangd commit: https://reviews.llvm.org/D143974 It is needed for macro enable in the C/C++ language
|
Not sure if this should/must be done in LSP4J |
|
@ghentschke Thank you for taking the time to submit this contribution.
As long as it is not in the LSP spec (and, as far as I can see, it is not in the current 3.17 version or the upcoming 3.18 version), it should not be done in LSP4J. If you think that it should become part of the spec, you can try to contribute this protocol extension to https://github.com/microsoft/language-server-protocol. Then, it could be supported by LSP4J... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this feature is needed for a clangd protocol extension. See this cdt-lsp issue eclipse-cdt/cdt-lsp#299 and this clangd commit: https://reviews.llvm.org/D143974 It is needed for macro enable in the C/C++ language