-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
527 added support for additional request headers in OslcQuery #553
527 added support for additional request headers in OslcQuery #553
Conversation
I still can't get the .editorconfig to work, neither in eclipse nor VS Code - so sorry for the format changes. Maybe someone can do the re-formatting if needed. |
93c5059
to
ed025c9
Compare
@jhemm2 The format changes are fine. It is actually an improvement where you are replacing our "tabs" with "white spaces". The change looks fine to me otherwise. @berezovskyi! The SonarCloud Code Analysis failed. What is the implications for this? |
ed025c9
to
717ea0d
Compare
Hello @Jad-el-khoury |
@jhemm2 thanks for the PR and the tests! @Jad-el-khoury the Sonar check is just FYI for the committers, not a blocking one. I think @jhemm2 added sufficient tests to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing, could you please add an entry under https://github.com/eclipse/lyo/blob/master/CHANGELOG.md#added like
- Support for additional request headers to OslcQuery.
Quality Gate failedFailed conditions |
717ea0d
to
bbc789c
Compare
Thank you again for the contribution, @jhemm2! It will land in Lyo Snapshot repo in less than an hour and on Central when we release Lyo 6. |
Description
Added support for additional request headers when creating and OSLCQuery
Checklist
Issues
Closes #527