create gitlab connector (#37)

[BeckerFrank]

Here is a POC of a gitlab connector (#37) with the following features.

• Using native gitlab REST API
• Using a gitlab.com account with oauth (user and password)
• Creating a repository configuration and insert projects and groups you are interested
• Creating queries for one or more projects and groups from the configuration
• Task editor for basic attributes including Notes
• Updating some, but not all attributes including add a new Note
• Creating a new task

@wimjongman @ruspl-afed @merks WDYT?

Should we continue or wait until 4.0 is done?

[ruspl-afed]

or wait until 4.0 is done?

I'm not sure what do you mean by this @BeckerFrank

Since upcoming 4.0.0 is major release, we are free to add & remove whatever we want, and GitLab support could be a nice addition to 4.0.0.
Especially after merging of #195 with releng preparation changes.

[BeckerFrank]

Now I have the a version with the following features.

• only work with https://gitlab.com repositories
• create queries and show issues for projects and groups
• create new issues
• create comments
• add comments to discussions

@wimjongman, @ruspl-afed, @merks, @gnl42 : please can you give some feedback.
I also want to know what I need to change before I can commit this to the main branch as a preview.
After this we can plan the next steps.

[wimjongman]

Hey Frank, I am out of office for a while.

[ruspl-afed]

What needs to be done:

1. license headers (add)
2. gitlab images (replace with some standard images and ask IP team how to proceed)
3. API (avoid declaring API on this stage)

All others may be done later

[ruspl-afed]

We need to put more work here before promoting this class to API, I suggest to move to internal package until it will be ready.

[gnl42]

Could you use the openapi spec (https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/api/openapi/openapi.yaml?plain=1) to generate the rest client code?

[BeckerFrank]

I will look into this in the near future how useful the generated client can be.
We can not generate the whole client because have hat to support TaskData Structure but hopefully this is only a small change.

[BeckerFrank]

We need to put more work here before promoting this class to API, I suggest to move to internal package until it will be ready.

done with next commit

[gnl42]

Side note, what would be needed to make IProgressMonitor autoclosable?

[ruspl-afed]

The use case is not fully clear for me. Do you mean to use in try-with-resources or something else @gnl42 ?

[gnl42]

The use case is not fully clear for me. Do you mean to use in try-with-resources or something else @gnl42 ?

Yes @ruspl-afed . So instead of:

	monitor = Policy.monitorFor(monitor);
		try {
			monitor.beginTask("Submitting_task", IProgressMonitor.UNKNOWN);
                        ...
		} finally {
			monitor.done();
		}

it would be:

		try (IProgressMonitor postMonitor = Policy.monitorFor(monitor)) {
			postMonitor.beginTask("Submitting_task", IProgressMonitor.UNKNOWN);
	                ...
		} 

[ruspl-afed]

This Policy.monitorFor(monitor) looks a bit outdated, currently we can use more modern https://github.com/eclipse-equinox/equinox/blob/master/bundles/org.eclipse.equinox.common/src/org/eclipse/core/runtime/SubMonitor.java that does not require finally block and have a lot of other improvements.

[merks]

@BeckerFrank

Sorry, I'm torn in so many different directions I can't find time for a review. 😞

[ruspl-afed]

here the license feature should be referenced that will bring proper license content.

[ruspl-afed]

@BeckerFrank we can merge it after resolving question with GitLab images and then improve it gradually

[BeckerFrank]

@BeckerFrank we can merge it after resolving question with GitLab images and then improve it gradually

Gitlab images are fine, but what is with the comment for mylyn.tasks/connectors/gitlab/org.eclipse.mylyn.gitlab.source.feature/feature.xml?

What is here needed?. How can I include this function in an update site without this source feature project?

[ruspl-afed]

Please resolve conflicts and have a look how source features represented in main

[ruspl-afed]

LGTM
I'll look at source feature later