Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#182] Add required 3rd party bundles #242

Merged
merged 5 commits into from
Jul 19, 2023
Merged

[#182] Add required 3rd party bundles #242

merged 5 commits into from
Jul 19, 2023

Conversation

ruspl-afed
Copy link
Contributor

@ruspl-afed ruspl-afed commented Jul 13, 2023

  • reworked "org.apache.*" dependencies from Require-Bundle to Import-Package
  • added missed bundle entries to category.xml

Rework of other dependencies like guava is planned for other PRs

@ruspl-afed ruspl-afed requested a review from merks July 13, 2023 07:58
Signed-off-by: Alexander Fedorov <[email protected]>
@merks
Copy link
Contributor

merks commented Jul 13, 2023

I'm not sure the plan here, but the cycle time for the testing will take way way too long. Please have a look at

#241

@ruspl-afed
Copy link
Contributor Author

I'll delay these changes, Ed @merks has quicker solution with #241

@ruspl-afed ruspl-afed marked this pull request as draft July 13, 2023 08:15
Rework apache dependencies from `Require-Bundle` to `Import-Package`

Signed-off-by: Alexander Fedorov <[email protected]>
@ruspl-afed ruspl-afed marked this pull request as ready for review July 19, 2023 07:37
Signed-off-by: Alexander Fedorov <[email protected]>
Complete `category.xml`

Signed-off-by: Alexander Fedorov <[email protected]>
@ruspl-afed
Copy link
Contributor Author

I plan to merge this one when pipeline will succeed Ed @merks

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this issue is highly relevant:

eclipse-orbit/orbit-simrel#1

There are lots of new versions of dependencies including new versions of lucene.

I want to get rid of this too:

eclipse-orbit/orbit#48

But some Orbit things on which Mylyn depends still explicitly use it...

None of this speaks against your changes rather that further changes will be relevant.

Import more `org.apache`packages for
`org.eclipse.mylyn.bugzilla.rest.core`

Signed-off-by: Alexander Fedorov <[email protected]>
@ruspl-afed ruspl-afed merged commit 24a5004 into main Jul 19, 2023
@ruspl-afed ruspl-afed deleted the prepare_4_0_0_M1 branch July 19, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants