Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that GitLab Repository has Issues enabled before fetching repo Milestones (#501) #502

Merged

Conversation

Paranoja
Copy link
Contributor

@Paranoja Paranoja commented Apr 28, 2024

GET /projects/:id respond with a list of Repository feature toggle states.

Fix for #501 checks if

{
...
  "issues_enabled": <boolean>
...
}

is set to true, then fetches Milestones. Otherwise, just returns an empty array.

@ruspl-afed ruspl-afed force-pushed the gitlab-ignore-projects-issue-disabled branch from e0d803e to d75d1e2 Compare May 3, 2024 05:46
@BeckerFrank
Copy link
Contributor

@Paranoja: Can you please look why the Test ignoreMilestonesForProjectsWithIssuesDisabled is not green.

@Paranoja
Copy link
Contributor Author

Paranoja commented May 5, 2024

Test failed due to JPMS. Will fix.

@Paranoja Paranoja force-pushed the gitlab-ignore-projects-issue-disabled branch 2 times, most recently from 6080232 to 966f982 Compare May 5, 2024 18:56
@ruspl-afed ruspl-afed force-pushed the gitlab-ignore-projects-issue-disabled branch from 966f982 to dbc432b Compare May 6, 2024 12:41
@Paranoja Paranoja force-pushed the gitlab-ignore-projects-issue-disabled branch from dbc432b to 2c23614 Compare May 6, 2024 16:37
Copy link
Contributor

@BeckerFrank BeckerFrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BeckerFrank BeckerFrank merged commit e4c0078 into eclipse-mylyn:main May 6, 2024
3 checks passed
@Paranoja Paranoja deleted the gitlab-ignore-projects-issue-disabled branch May 6, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants