JDK24 remove System.getSecurityManager part 2 #21002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
force-pushed
the
securitymanager_2
branch
from
550315c to
b14b819
Compare
JasonFengJ9
reviewed
Jan 23, 2025
| @@ -222,6 +226,7 @@ public String type() { | |||
| return "Java SE"; //$NON-NLS-1$ | |||
| } | |||
|
|
|||
| /*[IF JAVA_SPEC_VERSION < 24]*/ | |||
| private static void checkAttachSecurity() { | |||
There was a problem hiding this comment.
I think there are some AttachAPI security tests, do they pass with this change?
There was a problem hiding this comment.
My personal build build with sanity and extended personal tests looks okay. I don't think any of the failures are related. https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/25989/
theresa-m
commented
Jan 23, 2025
keithc-ca
requested changes
Jan 23, 2025
...rc/java.management/share/classes/com/ibm/java/lang/management/internal/MemoryMXBeanImpl.java
Show resolved
Hide resolved
theresa-m
force-pushed
the
securitymanager_2
branch
from
b14b819 to
7c381e6
Compare
Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
securitymanager_2
branch
from
7c381e6 to
20e3468
Compare
|
Jenkins test sanity alinux jdk21,jdk24 |
|
The openjdk failures seen here have been excluded adoptium/aqa-tests#5912. The functional failures are not related to this issue. |
JasonFengJ9
approved these changes
Jan 27, 2025
|
The other failure is #20351. |
keithc-ca
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #20563