-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor workflows and implement combined Java module release #852
Conversation
0002dc6
to
1d10f29
Compare
3d590a8
to
da68686
Compare
…. Wait for artifacts to hit Maven Central after release. Create GitHub releases.
9b8bfc1
to
ca8c922
Compare
Should we have the |
The deploy goal will automatically run the unit tests and integration tests so it will be spiked if they fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, quite a few interesting interactions when factoring in calls from other repos
Major changes:
The release all Java modules workflow combines pass-core, and pass-support into one module on the file system such that maven can have everything in the reactor.
Testing resulted in two full releases being made, 1.3.0-RC1 and 1.3.0-RC2. The commits for those versions no longer exist because history was rewritten. The tags to those commits for the releases are no longer valid. After this pr is merged, the tags should be reset to that commit.