-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #27
Update README.md #27
Conversation
README.md
Outdated
|
||
* [NodeJS](https://nodejs.org/en/) version 14+ | ||
* [Yarn](https://yarnpkg.com/) v1.x - package manager, similar to NPM | ||
PASS Docker is Open Source software released under the [Apache 2.0 license](LICENSE). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be PASS Acceptance Testing instead of PASS Docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
README.md
Outdated
@@ -1,14 +1,15 @@ | |||
## Description | |||
# PASS Acceptance Testing ![PASS Acceptance Testing](https://github.com/eclipse-pass/pass-acceptance-testing/actions/workflows/release.yml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot the /badge.svg
at the end of the badge url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
README.md
Outdated
@@ -1,14 +1,15 @@ | |||
## Description | |||
# PASS Acceptance Testing ![PASS Acceptance Testing](https://github.com/eclipse-pass/pass-acceptance-testing/actions/workflows/release.yml/badge.svg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, badge should be for the test.yml
workflow, this is the workflow that is more often used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
This PR will cleanup old documentation within the pass-acceptance-testing repository. It updates the top level README with a brief summary and adds URLS pointing to the new documentation site.
Related to eclipse-pass/main#1081. When merged PR 1081 will close the eclipse-pass/main#1035; however these PRs can be merged in any order.