Add delete permissions on File models

eclipse-pass · Jan 29, 2024 · 4c2407c · 4c2407c
1 parent 3804d33
commit 4c2407c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pass-core-main/src/test/java/org/eclipse/pass/main/security/AccessControlTest.java b/pass-core-main/src/test/java/org/eclipse/pass/main/security/AccessControlTest.java
@@ -386,7 +386,7 @@ public void testCreateUpdateDeleteFileAsShibUserOwningSubmission() throws IOExce
 
             Response response = client.newCall(request).execute();
 
-            check(response, 403);
+            check(response, 204);
         }
     }
 

diff --git a/pass-core-object-service/src/main/java/org/eclipse/pass/object/model/File.java b/pass-core-object-service/src/main/java/org/eclipse/pass/object/model/File.java
@@ -23,6 +23,7 @@
 import javax.persistence.Table;
 
 import com.yahoo.elide.annotation.CreatePermission;
+import com.yahoo.elide.annotation.DeletePermission;
 import com.yahoo.elide.annotation.Include;
 import com.yahoo.elide.annotation.UpdatePermission;
 import org.eclipse.pass.object.converter.FileRoleToStringConverter;
@@ -35,6 +36,7 @@
 
 @CreatePermission(expression = "User is Backend OR Object part of User Submission")
 @UpdatePermission(expression = "User is Backend OR Object part of User Submission")
+@DeletePermission(expression = "User is Backend OR Object part of User Submission")
 @Include
 @Entity
 @Table(name = "pass_file")
-Original file line number
+Diff line change
@@ Expand Up @@
                 Response response = client.newCall(request).execute();
-                check(response, 403);
+                check(response, 204);
             }
         }
@@ Expand Down @@