Add metadata schema for InvenioRDM along with a test #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsande16
approved these changes
May 20, 2024
There was a problem hiding this comment.
Looks good! Added tests pass locally for me. The only thing I might add, is adding some different schemas to test the robustness of the metadata schema service, but since this was a simple test the scope is fine. Really won't know how much Caltech metadata deviates from our global.json until we start developing the integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step for InvenioRDM suppport can just use a simple metadata schema that requires and author and publication date.
Later we may want to get more detailed name info from authors later on and so some work in pass-ui to get that work from the DOI.
Documented findings here: https://docs.google.com/document/d/1JllSJ48d14AvIVyhB0l0zUTcoj1vSB2oNlKRwi2wAVs/edit?usp=sharing