Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify DOI service to not return entries without a URL #94

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Conversation

markpatton
Copy link
Contributor

This PR updates the DOI service such that entries without a URL are not returned. In addition the returned filenames are parsed from the URL in a more reliable way so that we do not return filenames like blah.pdf?render=pdf.

Copy link
Contributor

@rpoet-jh rpoet-jh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@markpatton markpatton merged commit b1cbb2f into main Oct 14, 2024
2 checks passed
@markpatton markpatton deleted the 1053-doi branch October 14, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants