Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMF test candidate with updated pass-ember #231

Merged
merged 1 commit into from
Jul 17, 2019
Merged

CMF test candidate with updated pass-ember #231

merged 1 commit into from
Jul 17, 2019

Conversation

markpatton
Copy link
Contributor

@markpatton markpatton commented Jul 16, 2019

(This text is slightly modified from a previous pr created by @jabrah)

Bump version number of pass-ember to a candidate for testing.

Some issues still exist in this image, but the holiday fast approaches and I wanted to get something out for people to look at. If we'd rather wait for other fixes to come it before testing, then we could always close this PR in favor of a newer one.

Highlights

Select changes since the last version bump (~3 weeks ago):

  • When a user clicks the "Delete" button on a draft submission, they now have their status changed to cancelled instead of being fully deleted in Fedora to get around some nasty permission issues
  • Phantom draft submissions shouldn't appear in the submissions table anymore. Addressed a timing issue between "deleting" a draft submission and ES indexing that was causing deleted drafts to appear in the submissions table
  • Made metadata loaded from the DOI read only again in the metadata forms
  • Force DOI to be loaded when a user enters the submission workflow to address a few data consistency issues
  • Fixed bug where metadata from the DOI would not be cleared from the metadata forms when a user clears the DOI from the publication
  • Map Crossref field issued (date) to publicationDate in the metadata blob
  • Use an upgraded schema service to show a merged metadata form when possible. If a 409 error is seen from the service, the UI will try to get the unmerged forms to show the user
  • Display co-PIs better in grants details page
  • Force grants table and grant details page to ignore "deleted" submissions
  • Fix a bug related to changing grants: (Effective policies isn't updated correctly in some situations pass-ui#982)

Known Issues

There are still some major bugs known to be present in this image including:

@birkland birkland merged commit f2361f2 into master Jul 17, 2019
@birkland birkland deleted the ember_update branch July 17, 2019 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants