-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update IDP and LDAP containers #379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 6, 2024
…ey will load in the new version of 389 dirserv
…not require building a custom image
markpatton
force-pushed
the
1006-ldap-idp
branch
from
September 9, 2024 13:23
cfcdfed
to
0fdbbff
Compare
rpoet-jh
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, Mark! Just a few comments.
rpoet-jh
reviewed
Sep 9, 2024
rpoet-jh
reviewed
Sep 9, 2024
rpoet-jh
reviewed
Sep 9, 2024
rpoet-jh
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the LDAP and IDP containers to use new versions with maintained images. The containers are no longer built from custom images and instead existing images are customized appropriately. As a consequence the update image workflow is remove.
For acceptance tests to pass, this pr must first be merged: eclipse-pass/pass-acceptance-testing#24
In order to test, fire up the local environment and make sure you can login.