Update README files for default prop values cleanup #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markpatton I realized I have to fix the ITs for pass-support after merging the pass-core change for default prop values. I'll fix them and then reopen this PR. |
And update pass-core container config
|
Apparently github has some issues with reopened PRs and rebase and merge. Closed this PR and opened a new PR #130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the pass-support ITs that use pass-core by adding the pass-core-test-config directory and files and passing them into the container on startup. A few READMEs were also updated for default value cleanup.
eclipse-pass/main#1066