Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pass-core pass-core-test-config artifact #132

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

rpoet-jh
Copy link
Contributor

@rpoet-jh rpoet-jh commented Oct 30, 2024

For loading pass-core test configuration to support ITs.

Tests will not pass in this PR is merged and snapshots published: eclipse-pass/pass-core#99

To test this locally, get pass-core and checkout branch rdp-1071-test-config-cleanup. In pass-core, run mvn clean install. Then you should be able to run mvn clean verify in pass-support.

@rpoet-jh rpoet-jh self-assigned this Oct 30, 2024
@rpoet-jh rpoet-jh requested a review from markpatton October 30, 2024 17:11
@rpoet-jh rpoet-jh linked an issue Oct 30, 2024 that may be closed by this pull request
Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The test module is better than copying the config.

@rpoet-jh rpoet-jh force-pushed the rdp-1071-test-config-cleanup branch from 97c6ef6 to fecb8ba Compare November 1, 2024 14:15
@rpoet-jh rpoet-jh merged commit 3f7e452 into main Nov 1, 2024
2 checks passed
@rpoet-jh rpoet-jh deleted the rdp-1071-test-config-cleanup branch November 25, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make pass-core test configuration reusable
2 participants