Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README #137

Merged
merged 7 commits into from
Nov 20, 2024
Merged

Update README #137

merged 7 commits into from
Nov 20, 2024

Conversation

tsande16
Copy link
Contributor

This PR will cleanup old documentation within the pass-support repository. It updates the top level README with a brief summary and adds URLS pointing to the new documentation site.

Related to eclipse-pass/main#1081. When merged PR 1081 will close the eclipse-pass/main#1035; however these PRs can be merged in any order.

@tsande16 tsande16 self-assigned this Nov 18, 2024
README.md Outdated
submissions to downstream repositories such as PubMed Central and institutional repositories. Notification Services
provide alerts and updates to relevant stakeholders based on submission workflows and events.

You can find further documentation and details about the [Data Loaders](https://docs.eclipse-pass.org/developer-documentation/data-loaders),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about having a Guides section like on the Spring Boot README? https://github.com/spring-projects/spring-boot?tab=readme-ov-file#guides. I see it very similar where each of the links to our docs could be a bullet point.

Also, I think there should be a License section (something I see in almost every README). Something like https://github.com/spring-projects/spring-boot?tab=readme-ov-file#license

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some good points. I'm getting some feedback on others PRs, so I'm going to compile these and we can talk about them at our PASS Status meeting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

README.md Outdated

The pass-support repository contains components which sit outside pass-core.

# PASS Support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would also be good to add a badge next to the PASS Support for the status of the Publish SNAPSHOT workflow. The URL would be https://github.com/eclipse-pass/pass-support/actions/workflows/snapshot.yml/badge.svg, see https://docs.github.com/en/actions/monitoring-and-troubleshooting-workflows/monitoring-workflows/adding-a-workflow-status-badge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tsande16 tsande16 requested a review from rpoet-jh November 19, 2024 21:40
README.md Outdated
The pass-support repository contains components which sit outside pass-core.
PASS Support contains ancillary components that assist in the submission process and is composed of the Data Loaders,
Notification Services, and Deposit Services. The Data Loaders handle data ingestion from external systems like PubMed
Central, NIH, FIBI (JHU Grant Management System), transforming grant, journal, and manuscript submission data into a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change FIBI (JHU Grant Management System) to Grant Management System to keep it generic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Contributor

@rpoet-jh rpoet-jh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@markpatton markpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@tsande16 tsande16 merged commit 99efd51 into main Nov 20, 2024
2 checks passed
@tsande16 tsande16 deleted the 1035-update-repo-readme branch November 20, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants